Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow comments in queries to contain characters after # #43

Merged
merged 1 commit into from
Feb 1, 2017

Conversation

smgallo
Copy link
Contributor

@smgallo smgallo commented Jan 31, 2017

Allow comments in queries to contain characters after #

Description

Comments in JSON files are defined as any key starting with "#". This enables the same behavior in ETL query definitions (previously only a "#" was allowed and not "# name" for example).

Motivation and Context

Improve ETL inline documentation and testing workflow.

Tests performed

Tested with "#" and "# name" as comments, verified results are correct.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgallo smgallo added the enhancement Enhancement of the functionality of an existing feature label Jan 31, 2017
@smgallo smgallo added this to the v6.6.0 milestone Jan 31, 2017
@smgallo smgallo merged commit d4a59f1 into ubccr:xdmod6.6 Feb 1, 2017
@smgallo smgallo deleted the etl/improve-comments branch February 1, 2017 00:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants