Remove experimental shredder feature

[jtpalmer]

Description

Removes the getResourceForNode method from the shredder base class. This method was originally intended to provide a feature where the resource name could be determined from name of a node used by a job on a given day. This would allow for defining sub-resources within a given resource. It was never fully implemented and the removed method effectively returned the resource name that was set for a shredder instance (since the resource name is always required by the xdmod-shredder command).

The tests have also been improved to ensure that the resource name corresponds to the one which is set and not the resource name that may be contained in the accounting data (which is what is expected elsewhere in the ingestion process).

Motivation and Context

Since this feature was never fully implemented it provides no benefits and makes the code more complicated. Removing it simplifies the code and makes it easier to understand. It also fixes an issue where parsing the end time in SGE logs files fails.

Tests performed

Updated unit tests.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project as found in the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.