Fix uncaught ETL exception in PdoIngestor #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
approved these changes
Nov 4, 2018
eiffel777
approved these changes
Nov 5, 2018
smgallo
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is for 8.1
Description
Fix an uncaught exception when executing single database ingest statement. Also updated 2 catch blocks that were catching an exception, logging the error, and re-throwing the exception with more modern and functionally equivalent code for consistency.
Motivation and Context
Bugfix and code consistency.
Tests performed
Manually ran tests.
Types of changes
Checklist: