Add exception code to logAndThrowException #719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is for 8.1
Description
Loggable:logAndThrowException()
includes a message but does not include an error code. If an exception was provided in the options list, use the error code from that exception. Note that PDOException uses a string exception code (typically a five characters alphanumeric identifier defined in the ANSI SQL standard) while Exception uses an int. For these cases, use the driver specific error code instead so that we can propagate the error code with the newly thrown Exception.For a mapping of MySQL specific error codes to ANSI-SQL identifiers see https://dev.mysql.com/doc/refman/5.5/en/error-messages-server.html
Motivation and Context
@eiffel777 can utilize this information to decide whether or not cloud data is present and should be ingested/aggregated.
Tests performed
Manually ran tests.
Types of changes
Checklist: