Robustness improvements for integration tests #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
force-pushed
the
robustness
branch
2 times, most recently
from
0fe35e9 to
f30b1bd
Compare
plessbd
suggested changes
Nov 15, 2018
| @@ -268,35 +268,16 @@ public function testCreateReport(array $options) | |||
| } | |||
|
|
|||
| // render the charts as volatile | |||
There was a problem hiding this comment.
looks like this comment can be removed as well since it is on 276 as wel
plessbd
approved these changes
Nov 19, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve robustness of integration tests