Support asynchronous loading of Usage tab thumbnail charts #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
added a commit
to jpwhite4/xdmod
that referenced
this pull request
Dec 19, 2018
This patch reverts commit 43fa0377154e35ec639968ffefe95c88f38186b4 from Wed Nov 25 10:12:49 2015 -0500. Prior to this change, the Usage tab in XDMoD displayed a thumbnail view by default. The thumbnail view showed multiple charts, one for each of the statistics of the first node in the catalog. The XDMoD code was changed to use the metric explorer backend to generate the data for the Usage tab. Unfortunately, the changes resulted in terrible load performance for the thumbnail view. A short term workaround was implemented in commit 43fa0377154e35ec639968ffefe95c88f38186b4. This workaround loaded one of the charts by default rather than the thunmbnail chart view. The changes in ubccr#750 mitigate the slowness so this pull request reverts the workaround.
jtpalmer
added
the
enhancement
plessbd
previously approved these changes
Dec 19, 2018
There is no need to set a storeId since the store is not referenced elsewhere. Setting the storeId results in the store being registered with the store manager and will interfere with the garbage collector
plessbd
approved these changes
Dec 20, 2018
smgallo
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thumbnail charts view in the Usage tab has been painfully slow since the usage backend was replaced by a shim layer that uses the metric explorer backend.
This pull request does not fix the poor performance of the backend code. Instead it makes the thumbnail charts load asynchronously. The user interface is still responsive while the charts are loading and the charts are loaded from top to bottom so the visible ones are likely to be rendered first (although this is not guaranteed due to the async nature).
Changing the loader code to only load the visible charts is left as an exercise for Ben.