Add node_modules to the RPM. #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update the included packages list in the documentation |
plessbd
previously approved these changes
Mar 4, 2019
plessbd
approved these changes
Mar 22, 2019
plessbd
added
the
enhancement
jpwhite4
added a commit
to jpwhite4/xdmod-supremm
that referenced
this pull request
Mar 25, 2019
jpwhite4
added a commit
to ubccr/xdmod-supremm
that referenced
this pull request
Mar 26, 2019
Module changes needed for ubccr/xdmod#835
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_modules dependencies are now packaged in the RPM. There will be a corresponding update to the supremm RPM to account for this.
This change includes a %pre hook in the rpm that saves the (non-rpm managed) node_modules directory that could be present on an upgrade. This %pre hook should be removed by the next release. I have included a defensive check to ensure that the save code only runs when the version of the rpm is 8.1.0