Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update GroupBys In Cloud Aggregate Table #863

Merged
merged 4 commits into from
Mar 21, 2019

Conversation

chakrabortyr
Copy link
Contributor

Description

Added missing group by ids to the aggregate table generation.

Motivation and Context

To ensure our drilldowns/group bys in the portal work properly

Tests performed

Ran regression + integration tests in Docker to make sure those didn't break.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@chakrabortyr chakrabortyr added the bug Bugfixes label Mar 19, 2019
@chakrabortyr chakrabortyr added this to the 8.1.0 milestone Mar 19, 2019
@chakrabortyr chakrabortyr requested a review from jpwhite4 March 20, 2019 15:01
@chakrabortyr chakrabortyr merged commit 9ef0052 into ubccr:xdmod8.1 Mar 21, 2019
@chakrabortyr chakrabortyr deleted the RC_UpdateGroupByIds branch March 21, 2019 13:54
jtpalmer pushed a commit to jtpalmer/xdmod that referenced this pull request Mar 21, 2019
@chakrabortyr chakrabortyr added the Category:Cloud Cloud Realm label Mar 26, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bugfixes Category:Cloud Cloud Realm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants