enable all component tests and make sure they work #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
force-pushed
the
fix-component-tests
branch
from
9bceb87 to
e3d1954
Compare
plessbd
force-pushed
the
fix-component-tests
branch
from
e3d1954 to
737e627
Compare
ryanrath
approved these changes
Apr 30, 2019
plessbd
added
bug
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of the component tests were not being run due to #634, this re-enables them and makes them actually pass again.
The reason for the duration changes is due to how the calculation for "minmax" is done
Originally it was based on min job submit/start/end time, then when the cloud realm was added (#620) it was locally modified so that we could get the data since the original calculation used the jobfact table to get the data.
After this the tests were inadvertently disabled in #624 the calculation was changed to use the aggregate tables in #717 this should have been updated as the aggregate tables do not use submit time as a start.
If @jpwhite4 wants to correct or update this explanation he is free to do so