Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Treat byte slices as binary blobs in Any #339

Merged
merged 3 commits into from
Feb 24, 2017
Merged

Treat byte slices as binary blobs in Any #339

merged 3 commits into from
Feb 24, 2017

Conversation

ansel1
Copy link
Contributor

@ansel1 ansel1 commented Feb 24, 2017

Before opening your pull request, please make sure that you've:

Thanks for your contribution!

@mention-bot
Copy link

@ansel1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akshayjshah, @prashantv and @pravj to be potential reviewers.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm going to push a commit to change the docs a bit and then land.

@akshayjshah akshayjshah changed the title zap.Any() maps []byte and []uint8 values to zap.Binary() #335 Treat byte slices as binary blobs in Any Feb 24, 2017
@akshayjshah akshayjshah merged commit 12592ca into uber-go:master Feb 24, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants