Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make line endings configurable #424

Merged
merged 2 commits into from
May 5, 2017
Merged

Conversation

alaczi
Copy link
Contributor

@alaczi alaczi commented May 4, 2017

Add LineEnding to EncoderConfig, which allows Windows users to use non-Unix newlines.

Fixes #412.

@CLAassistant
Copy link

CLAassistant commented May 4, 2017

CLA assistant check
All committers have signed the CLA.

…g LineSeparator to the encoder configuration
@akshayjshah akshayjshah changed the title Adding possibility to configure line separator for log lines Make line endings configurable May 5, 2017
@akshayjshah
Copy link
Contributor

@alaczi This is great - thanks for the contribution! The test coverage is great.

I'm going to push a commit that changes LineSeparator to LineEnding, which is the term I see used more widely. Other than that small change, this is ready to merge 🎉

Copy link
Contributor

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gr8

@akshayjshah akshayjshah merged commit cea6c27 into uber-go:master May 5, 2017
@alaczi alaczi deleted the line_ending branch May 8, 2017 08:09
@alaczi
Copy link
Contributor Author

alaczi commented May 8, 2017

Cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants