Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MapEncoder: Store strings in map when AddByteString is used #504

Merged
merged 3 commits into from
Sep 25, 2017

Conversation

prashantv
Copy link
Collaborator

Fixes #503.

@codecov
Copy link

codecov bot commented Sep 22, 2017

Codecov Report

Merging #504 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files          37       37           
  Lines        2243     2243           
=======================================
  Hits         2180     2180           
  Misses         56       56           
  Partials        7        7
Impacted Files Coverage Δ
zapcore/memory_encoder.go 98.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9ca91...089228e. Read the comment docs.

@akshayjshah
Copy link
Contributor

If you also add a changelog entry, we can just cut a patch as soon as this lands.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants