Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add RFC3339, RFC3339Nano and update docs to include 'nano' #736

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Add RFC3339, RFC3339Nano and update docs to include 'nano' #736

merged 2 commits into from
Aug 21, 2019

Conversation

uhthomas
Copy link
Contributor

I was going to open an issue but #659 is already open.

Go's time package suggests that 'RFC3339 should be preferred for new protocols' so it would be great to have RFC3339 as a standard time format in zap.

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@prashantv prashantv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @uhthomas

Can you please include unit tests in encoder_test.go

@uhthomas
Copy link
Contributor Author

@prashantv Absolutely! I've added some unit tests :)

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #736 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   97.43%   97.44%   +<.01%     
==========================================
  Files          40       40              
  Lines        2109     2117       +8     
==========================================
+ Hits         2055     2063       +8     
  Misses         46       46              
  Partials        8        8
Impacted Files Coverage Δ
zapcore/encoder.go 84.61% <100%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9fa7d...b39d461. Read the comment docs.

@uhthomas
Copy link
Contributor Author

Awesome, thanks for the approval @prashantv! What's required to get this merged?

@prashantv
Copy link
Collaborator

Nothing else needed, I'll merge now :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants