consoleEncoder: put cloned jsonEncoder back to pool #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wyxloading
force-pushed
the
jsonencoder_in_pool
branch
from
bb9aed3 to
6b618ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 43 43
Lines 2368 2371 +3
=======================================
+ Hits 2329 2332 +3
Misses 32 32
Partials 7 7
Continue to review full report at Codecov.
|
consoleEncoder clone a jsonEncoder in `writeContext`, but never put back to pool after use. This make zap do more memory allocations, and may increase gc time.
wyxloading
force-pushed
the
jsonencoder_in_pool
branch
from
6b618ff to
4b59b9c
Compare
Closed
prashantv
approved these changes
Jul 29, 2020
Co-authored-by: Prashant Varanasi <github@prashantv.com>
prashantv
approved these changes
Aug 3, 2020
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
consoleEncoder clone a jsonEncoder in `writeContext`, but never put back to pool after use. This make zap do more memory allocations, and may increase gc time.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR put back the cloned
jsonEncoderinconsoleEncoderto_jsonPoolas mentioned in #851Tested and got no errors ( with race detector )
make testgo test -race -run="^$$" -bench="BenchmarkZapConsole" ./zapcore