Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support primitive static final fields as constant args in access paths #1105

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

msridhar
Copy link
Collaborator

Noticed a case like this in Uber code.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.10%. Comparing base (b7dad0c) to head (329f01c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...in/java/com/uber/nullaway/dataflow/AccessPath.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1105      +/-   ##
============================================
- Coverage     88.11%   88.10%   -0.02%     
  Complexity     2208     2208              
============================================
  Files            84       84              
  Lines          7177     7177              
  Branches       1424     1425       +1     
============================================
- Hits           6324     6323       -1     
  Misses          430      430              
- Partials        423      424       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit f17b330 into master Dec 21, 2024
9 of 11 checks passed
@msridhar msridhar deleted the primitive-static-field-constant-arg branch December 21, 2024 01:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants