Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue with annotations in module-info.java files #1109

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

msridhar
Copy link
Collaborator

javac generates AssignmentTrees for assigning annotation attributes that, in the context of a module-info.java file, was causing a crash. Just skip analysis of such assignments.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (f17b330) to head (d922324).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1109   +/-   ##
=========================================
  Coverage     88.10%   88.10%           
- Complexity     2208     2209    +1     
=========================================
  Files            84       84           
  Lines          7177     7179    +2     
  Branches       1425     1426    +1     
=========================================
+ Hits           6323     6325    +2     
  Misses          430      430           
  Partials        424      424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit d0502e8 into master Dec 22, 2024
11 checks passed
@msridhar msridhar deleted the module-info-assignment branch December 22, 2024 18:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants