Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add an option to disable shape and type checking #364

Merged
merged 1 commit into from
May 28, 2020
Merged

Add an option to disable shape and type checking #364

merged 1 commit into from
May 28, 2020

Conversation

VivekPanyam
Copy link
Collaborator

@VivekPanyam VivekPanyam commented May 27, 2020 •
edited
Loading

Allow users to disable runtime shape and type checking

Closes #326

@VivekPanyam VivekPanyam linked an issue May 27, 2020 that may be closed by this pull request
Add an option to disable shape and type checking from C++ #326
Closed
@codecov
Copy link

codecov bot commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #364 into master will decrease coverage by 0.04%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   89.44%   89.39%   -0.05%     
==========================================
  Files          57       57              
  Lines        3914     3896      -18     
==========================================
- Hits         3501     3483      -18     
  Misses        413      413
Impacted Files Coverage Δ
source/neuropod/backends/tensorflow/tf_tensor.hh 88.46% <66.66%> (ø)
source/neuropod/backends/neuropod_backend.cc 94.41% <100.00%> (+0.10%) ⬆️
source/neuropod/multiprocess/multiprocess.cc 78.75% <100.00%> (ø)
...ource/neuropod/multiprocess/multiprocess_worker.cc 95.45% <100.00%> (ø)
...od/multiprocess/serialization/ipc_serialization.hh 93.33% <100.00%> (-1.12%) ⬇️
source/neuropod/internal/backend_registration.cc 75.19% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ba3c2...e0c7870. Read the comment docs.

@VivekPanyam VivekPanyam mentioned this pull request May 27, 2020
Merged
@VivekPanyam VivekPanyam requested a review from selitvin May 27, 2020 08:04
vkuzmin-uber
vkuzmin-uber approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@vkuzmin-uber vkuzmin-uber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be useful for us. I also found that our service before relied a little bit that TF can deal with Input. I changed service to do "admit" check and conversion on our side now and maybe for efficiency we can use this "skip". This is useful!

VivekPanyam added a commit that referenced this pull request May 28, 2020
@VivekPanyam
[OPE] Pass RuntimeOptions to the worker process (#363)
11ba3c2 
This PR passes user-specified `RuntimeOptions` to the OPE worker process when loading a model.

This enables us to easily add options without having to write special logic for OPE.

See #361 and #364 for examples.
Base automatically changed from ope_options to master May 28, 2020 16:45
@VivekPanyam VivekPanyam force-pushed the option_shape_type_checks branch from 6fb7185 to e0c7870 Compare May 28, 2020 18:13
@VivekPanyam VivekPanyam merged commit 30bbdbc into master May 28, 2020
@VivekPanyam VivekPanyam deleted the option_shape_type_checks branch May 28, 2020 18:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@selitvin selitvin selitvin approved these changes

@vkuzmin-uber vkuzmin-uber vkuzmin-uber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to disable shape and type checking from C++
3 participants
@VivekPanyam @selitvin @vkuzmin-uber