sankey chart: fix labels' horizontal position #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like it is more wrong than the previous version to me? Like now the labels are overlapping |
|
@mcnuttandrew I guess |
|
Fair enough, in that line I'm cool with that change, I'm adding some more functionality to enable that type of per label behaviour #918 |
|
@mcnuttandrew That's cool. And thanks for your quick responses on these PRs! |
dvnrsn
pushed a commit
to dvnrsn/react-vis
that referenced
this pull request
Aug 21, 2018
* Make scatterplot voronoi more visible * impove previous voronoi scatterplot example center sankey chart labels (uber#915) fix horizontal position for sankey chart labels (uber#916) Make voronoi component automatically infer scales and extent (uber#917) * Make voronoi component automatically infer scales and extent * fix lint * address nits include option to specify padAngle, default to 0 Merge pull request #1 from uber/master merge changes add documentation for use in arc-series and radial-chard Merge branch 'master' of github.com:dvnrsn/react-vis adjust base radial chart test to make sure padAngle prop doesn't break Add default padangle to radius chart allow padangle to be either function or number, make invocation more ter
ayarcohaila
pushed a commit
to ayarcohaila/react-vis
that referenced
this pull request
Jun 30, 2021
ayarcohaila
added a commit
to ayarcohaila/react-vis
that referenced
this pull request
May 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #906
before:
after:
