Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LineSeriesCanvas - onNearestXY not called #931

Merged
merged 9 commits into from
Sep 10, 2018
Merged

LineSeriesCanvas - onNearestXY not called #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b7c6842
fix
IG-88-2 Aug 22, 2018
70806d4
fix lint
IG-88-2 Aug 23, 2018
3fb1faa
remove windows related commands
IG-88-2 Aug 23, 2018
3cf184d
suggested fixes
IG-88-2 Aug 28, 2018
c8c9746
fix showcase
IG-88-2 Aug 29, 2018
76f837a
remove windows lint rule
IG-88-2 Aug 29, 2018
921066e
append showcase to index
IG-88-2 Sep 10, 2018
a3dcc24
fix
IG-88-2 Sep 10, 2018
529b34c
move showcase
IG-88-2 Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
"build": "npm run clean && babel src -d dist --copy-files && BABEL_ENV=es babel src -d es --copy-files && node-sass src/main.scss dist/style.css --output-style compressed && npm run build:browser",
"lint": "eslint src tests showcase docs --ignore-pattern node_modules --ignore-pattern bundle.js",
"lint-styles": "stylelint src/styles/*.scss --syntax scss",
"test": "node --inspect node_modules/.bin/babel-node tests/index.js",
"test:windows": "babel-node --inspect ./tests/index.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wasn't intended to remove test command just one i created for windows, not sure how this happen, i added my own because i cant "npm run test" on windows, i have error ( this one jeffrifwald/babel-istanbul#70 ) , same goes for lint i should add "linebreak-style": ["error", "windows"]" to make it work, probably tests wasn't meant to run on windows platform

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's super weird! i don't really know what to do about it. Maybe file a bug and it can be looked into separately?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i will create separate issue for this

"test": "node --inspect ./node_modules/.bin/babel-node ./tests/index.js",
"full-test": "npm run lint && npm run cover",
"cover": "nyc --reporter=text --reporter=html --reporter=lcov npm test",
"remove-unpm-rfs": "./remove-refs-to-unpm.pl"
Expand Down
Loading