Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix map typedef key bug #332

Merged
merged 1 commit into from
Feb 20, 2018
Merged

fix map typedef key bug #332

merged 1 commit into from
Feb 20, 2018

Conversation

jakelarkn
Copy link
Contributor

No description provided.

jakelarkn
jakelarkn commented Feb 16, 2018
View reviewed changes
codegen/type_converter_test.go

// Todo Test Override cases

func TestConvertMapTypeDefToStruct(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the bug we hit. in the Map generation Typedef string alias (e.g. UUID) Key did have proper handling for Struct value

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 67.806% when pulling a29276c on jl/type_converter_map_typedef_fix into fde7746 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 67.806% when pulling a29276c on jl/type_converter_map_typedef_fix into fde7746 on master.

@oliviazhang0809
Copy link
Contributor

nice work!

@jakelarkn jakelarkn merged commit 0ce0f16 into master Feb 20, 2018
@jakelarkn jakelarkn deleted the jl/type_converter_map_typedef_fix branch February 20, 2018 01:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@oliviazhang0809 oliviazhang0809 oliviazhang0809 approved these changes

@cl1337 cl1337 cl1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakelarkn @coveralls @oliviazhang0809 @cl1337