Replace mockery with mockgen for mock generation #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuntaoLu
force-pushed
the
lu.mockgen
branch
from
deb1b9b to
ae8a5b1
Compare
ChuntaoLu
force-pushed
the
lu.mockgen
branch
from
ae8a5b1 to
28b4fb9
Compare
jacobgreenleaf
suggested changes
Feb 21, 2018
codegen/runner/post-steps.sh
Outdated
|
|
||
| if ! [ -x "$(command -v mockgen)" ]; then | ||
| go get -u github.com/golang/mock/gomock | ||
| go get -u github.com/golang/mock/mockgen |
There was a problem hiding this comment.
Tooling should be pinned in glide.yaml so we have reproducible results.
| @@ -27,7 +27,7 @@ func TestSaveContactsCall(t *testing.T) { | |||
| } | |||
| clientResponse := &clientContacts.SaveContactsResponse{} | |||
|
|
|||
| ms.MockClientNodes().Contacts.On("SaveContacts", mock.Anything, mock.Anything, clientRequest). | |||
| ms.MockClientNodes().Contacts.EXPECT().SaveContacts(gomock.Any(), gomock.Any(), clientRequest). | |||
There was a problem hiding this comment.
Nice, I like how the mocks are statically typed.
ChuntaoLu
force-pushed
the
lu.mockgen
branch
from
774837f to
939bc7f
Compare
jacobgreenleaf
approved these changes
Feb 22, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the mock generation lib from mockery to mockgen, because
Unfortunately, mockgen currently does not support anonymous struct types (golang/mock#153), so I have to temporarily unexpose client methods that consume/return anonymous struct types.