Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add option to force project references export #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShawnCZek
Copy link
Contributor

Similarly to #219, I am working on sharing the precompiled header between multiple projects. To make this possible, the other projects must be exported as a reference. MSVC does otherwise not wait for the compilation to finish.

Right now, project references are not exported for static libraries. And while ExportAdditionalLibrariesEvenForStaticLib exists as a configuration option, it does more things at once, often resulting in already defined in X.lib(X.dll); second definition ignored warnings.

Therefore, this pull request adds an option to force the export of these references regardless of the output type of the project.

@jspelletier
Copy link
Collaborator

jspelletier commented Mar 22, 2023

Hi,
Sorry for the lack of updates. Lambert left Ubisoft and we had to rebuild a new maintainer group.

We will take a look at this MR soon.

@bchampoux
Copy link
Member

@jspelletier is this related to #146? it's the same config option

@jspelletier jspelletier changed the base branch from dev to main April 6, 2023 12:54
@jspelletier
Copy link
Collaborator

@ShawnCZek could you add/modify some sample using this?

@ShawnCZek
Copy link
Contributor Author

@jspelletier I can take a look at trying to integrate this into existing samples. However, as pointed out earlier here, #253 basically collides with this PR. And if that one is merged, this can be closed.

@jspelletier
Copy link
Collaborator

@ShawnCZek The problem with #253 is it doesn't have an explicit option and will affect our existing generated files so it won't ever be merged in its current state,

@ShawnCZek
Copy link
Contributor Author

Perfect. Thank you for the answer! In the following days, I will take a look at modifying the existing samples to integrate this change. Once that is done, I will mention you here again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants