-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make rofi theme configurable #53
Conversation
Thanks for this change - it works very well. I would suggest keeping |
@twa022 - this PR just became very complex very quickly. I suggest sticking with the |
@vkareh: fair enough. I reverted the commits that enabled additional configuration options and committed a change to set the default theme back to docu and to add instructions on how to change the theme in the README. I didn't mention |
That said I do think it would be a good idea to reevaluate the default theme. You can see in the picture on #52 that with the docu theme you cannot actually tell what some of the menu items are as too much text is truncated to tell them apart. Perhaps the project could include its own rofi .rasi theme. |
I agree with the concern, but I'll let @flexiondotorg make that decision. I think adding a This new change works well for me, thanks! Can you squash your commits into a single one to clean up the history? |
@vkareh: Done (I did not know you could do that, and my git histories will be much prettier now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
LGTM
@twa022 Thank you for working on this. I'll get it packages and released ASAP. I do agree that adding a |
Release 22.04.0 hardcodes mate-hud to use the rofi docu theme which in my opinion makes it more difficult to use.
This changes the default to Arc-Dark (feel free to pick whatever you want) but also makes the rofi theme configurable in gsettings.