Added Loading.tsx component and integrated Suspense #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review and let me know |
src/pages/Loading.tsx
Outdated
There was a problem hiding this comment.
can Loader get moved to src/components? I prefer not to start adding elements in the pages directory.
There was a problem hiding this comment.
Done sir ! Made the changes
There was a problem hiding this comment.
Let me know if there’s anything else that needs to be addressed
craigrbarnes
approved these changes
Jan 24, 2025
|
Thank you @craigrbarnes ..Is there any other way so that I can contribute?Any repos? |
craigrbarnes
added a commit
to uc-cdis/bih-data-commons
that referenced
this pull request
Jan 28, 2025
* remove override name in quay build (#17) Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> * Update package.json (#19) * Update package.json * update package-lock to v0.10.15 --------- Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> * Add Gen3FF updates to sample app (#23) * add updates to sample app * Add modals config --------- Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> * fix broken links/missing images (#24) Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> * Chore/update to Gen3.2 version 0.10.30 (#29) * update config and dependencies * update config/package.json * add eslint/prettier * update typescript esplugin * update github ci * update Dockerfile * Chore/patch 0 10 31 (#36) * update config and dependencies * update config/package.json * add eslint/prettier * update typescript esplugin * update github ci * update Dockerfile * update to 0.10.31 * update to 0.10.31 * update dockerfile * update dockerfile * update dockerfile * update dockerfile * update dockerfile * update docker * testing update build ci * testing update build ci * Delete .idea directory * update docker * Update Dockerfile * update Docker * Update to 0.10.44 (#41) * update to 0.10.44 * update to 0.10.44 * update mantine and style for tailwind * update changed to support v0.10.48 (#46) * update changed to support v0.10.48 * update changed to support v0.10.50 * add next js config flags * Chore/0.10.51 (#49) * update v0.10.51 * update version to v0.10.51 * update Dockerfile * Update to Gen3.2 Release 0.10.55 (#53) Update to Gen3.2 v0.10.55 * Update CustomCellRenderers.tsx to DicomLink (#52) * update git workflows node version, remove automated npm update (#55) Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> * Update/release 0 10 67 (#57) * update version to v0.10.61 * update version to v0.10.67 * update version to v0.10.67 * Update ci.yaml * update build to use start.sh for automation (#59) Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> * update to 0.10.73 (uc-cdis#63) * Chore/update docker (uc-cdis#64) * update Dockerfile * update .env files * Chore/update 0.10.74 (uc-cdis#66) * update Dockerfile * update .env files * update to gen3.2 0.10.74 * Added Loading.tsx component and integrated Suspense (uc-cdis#65) * Added Loading.tsx component and integrated Suspense * Moved Loading.tsx to components folder and updated _app.tsx * update to 0.10.77 (uc-cdis#67) * update to 0.10.78 (uc-cdis#68) * add package lock * update Diacom to Dicom --------- Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> Co-authored-by: Albert Snow <ajsnow2012@gmail.com> Co-authored-by: Shawn O'Connor <ocshawn@ocshawn.com> Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> Co-authored-by: Advaith Mahendrakar <120632885+AdvaithMahendrakar12@users.noreply.github.com>
craigrbarnes
added a commit
to uc-cdis/vadc-data-commons
that referenced
this pull request
Jan 30, 2025
* Update/release 0 10 67 (uc-cdis#57) * update version to v0.10.61 * update version to v0.10.67 * update version to v0.10.67 * Update ci.yaml * update build to use start.sh for automation (uc-cdis#59) Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> * update to 0.10.73 (uc-cdis#63) * Chore/update docker (uc-cdis#64) * update Dockerfile * update .env files * Chore/update 0.10.74 (uc-cdis#66) * update Dockerfile * update .env files * update to gen3.2 0.10.74 * Added Loading.tsx component and integrated Suspense (uc-cdis#65) * Added Loading.tsx component and integrated Suspense * Moved Loading.tsx to components folder and updated _app.tsx * update to 0.10.77 (uc-cdis#67) * update to 0.10.78 (uc-cdis#68) --------- Co-authored-by: Shawn O'Connor <ocshawn@ocshawn.com> Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> Co-authored-by: Advaith Mahendrakar <120632885+AdvaithMahendrakar12@users.noreply.github.com>
paulineribeyre
pushed a commit
to uc-cdis/bih-data-commons
that referenced
this pull request
Jan 30, 2025
* add multitab explorer config * updated BIH staging FE config * updated BIH staging FE config * updated BIH staging landing page blurbs * Update to 0.10.78 (#52) * remove override name in quay build (#17) Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> * Update package.json (#19) * Update package.json * update package-lock to v0.10.15 --------- Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> * Add Gen3FF updates to sample app (#23) * add updates to sample app * Add modals config --------- Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> * fix broken links/missing images (#24) Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> * Chore/update to Gen3.2 version 0.10.30 (#29) * update config and dependencies * update config/package.json * add eslint/prettier * update typescript esplugin * update github ci * update Dockerfile * Chore/patch 0 10 31 (#36) * update config and dependencies * update config/package.json * add eslint/prettier * update typescript esplugin * update github ci * update Dockerfile * update to 0.10.31 * update to 0.10.31 * update dockerfile * update dockerfile * update dockerfile * update dockerfile * update dockerfile * update docker * testing update build ci * testing update build ci * Delete .idea directory * update docker * Update Dockerfile * update Docker * Update to 0.10.44 (#41) * update to 0.10.44 * update to 0.10.44 * update mantine and style for tailwind * update changed to support v0.10.48 (#46) * update changed to support v0.10.48 * update changed to support v0.10.50 * add next js config flags * Chore/0.10.51 (#49) * update v0.10.51 * update version to v0.10.51 * update Dockerfile * Update to Gen3.2 Release 0.10.55 (#53) Update to Gen3.2 v0.10.55 * Update CustomCellRenderers.tsx to DicomLink (#52) * update git workflows node version, remove automated npm update (#55) Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> * Update/release 0 10 67 (#57) * update version to v0.10.61 * update version to v0.10.67 * update version to v0.10.67 * Update ci.yaml * update build to use start.sh for automation (#59) Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> * update to 0.10.73 (uc-cdis#63) * Chore/update docker (uc-cdis#64) * update Dockerfile * update .env files * Chore/update 0.10.74 (uc-cdis#66) * update Dockerfile * update .env files * update to gen3.2 0.10.74 * Added Loading.tsx component and integrated Suspense (uc-cdis#65) * Added Loading.tsx component and integrated Suspense * Moved Loading.tsx to components folder and updated _app.tsx * update to 0.10.77 (uc-cdis#67) * update to 0.10.78 (uc-cdis#68) * add package lock * update Diacom to Dicom --------- Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> Co-authored-by: Albert Snow <ajsnow2012@gmail.com> Co-authored-by: Shawn O'Connor <ocshawn@ocshawn.com> Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> Co-authored-by: Advaith Mahendrakar <120632885+AdvaithMahendrakar12@users.noreply.github.com> --------- Co-authored-by: craigrbarnes <craig.barnes@intelligentlight.com> Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu> Co-authored-by: Albert Snow <ajsnow2012@gmail.com> Co-authored-by: Shawn O'Connor <ocshawn@ocshawn.com> Co-authored-by: Shawn O'Connor <shawnoconnor@uchicago.edu> Co-authored-by: Advaith Mahendrakar <120632885+AdvaithMahendrakar12@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Added Loading Component
Made the Changes in _app.tsx