Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include uncataloged id's in item record search #438

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

crowesn
Copy link
Contributor

@crowesn crowesn commented Mar 5, 2024

Resolves #418

The search controller was using a restrictive regex to identify item record numbers in search strings, looking for precise pattern of a string initilized by a single lower-case "i", followed by a series of numeric characters. Not all records have these item-record numbers: those without are assigned an identifier initialized with 'notcat' and a series of numeric characters. Staff expected the "notcat" identifiers to be retrievable via search but results excluded these records.

To fix, we edit the regex patter for item-record retrieval to include any initial alpha character series followed by digits. This will return results with identifiers initialized with "i", "notcat" and any other series of alpha characters followed by numeric characters.

@crowesn crowesn changed the title Include uncataloged id in item record search Include uncataloged id's in item record search Mar 5, 2024
@Janell-Huyck Janell-Huyck self-assigned this Mar 6, 2024
@Janell-Huyck
Copy link
Contributor

Looks good for expanding search abilities while maintaining performance. We're assuming no titles will start with i1234 or notcat1234, which seems reasonable.

Copy link
Contributor

@Janell-Huyck Janell-Huyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected when deployed to libappstest.

@Janell-Huyck Janell-Huyck merged commit 668b568 into qa Mar 6, 2024
3 checks passed
@Janell-Huyck Janell-Huyck deleted the 418/item-record-search branch March 6, 2024 21:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDs with initial alpha characters yield not results in search.
2 participants