MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST #475

Janell-Huyck · 2024-04-19T22:19:46Z

Relates to #214

This PR checks whether or not the four user types (non-authenticated, read-only, standard, and admin) can view the following pages:

conservation records (index page)
conservation record (single instance)
controlled vocabularies
users
activity
staff codes
reports

This is done by logging the user in using contexts, and then using shared examples for what the user should be able to see (it_behaves_like 'view controlled vocabularies'), or helper methods (prevents_anonymous_access and prevents_unauthorized_access) for pages that the user should not be able to access.

We use those two different helper methods because the messages and redirects are different for logged-in but unauthorized users vs users who haven't logged in. Users who can view a page are referred to the shared examples. A user who isn't permitted to view those pages would fail the tests, so instead they are referred to the helper methods that check their refusal.

This PR does not check whether a user can edit or create any records. That will be addressed in a different PR.

crowesn

Very good. Merging.

* Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time

…#487) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests

* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix broken test

* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests

* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * Fix failing test

* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests

…IRST (#492) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests * Migrate controlled vocab creation specs * Correct spelling name of test