Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

509- Set up to use nvm for deploys and circleci #511

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Janell-Huyck
Copy link
Contributor

@Janell-Huyck Janell-Huyck commented May 30, 2024

Fixes #509

Our servers are now using nvm to set node versions. This PR is to set up Treatment Database to take advantage of this new configuration.

  • Adds .nvmrc file to specify node version to use. I know that at least 18 will be needed in a future Treatment Database version, but the latest Node LTS version is actually 20.14.0, so I set our .nvmrc to that.
  • Adds a capistrano rake task to install (if necessary) and use the version of node listed in the .nvmrc file.
  • Modifies the circleci config file to download nvm and install & use the version of node that is listed in the .nvmrc file. This is to keep our deployment in step with our testing.
  • Updates README

@Janell-Huyck Janell-Huyck changed the title 509- Set up to use nvm for deploys and circleci WIP 509- Set up to use nvm for deploys and circleci May 30, 2024
@Janell-Huyck Janell-Huyck changed the title WIP 509- Set up to use nvm for deploys and circleci 509- Set up to use nvm for deploys and circleci May 30, 2024
@hortongn hortongn self-requested a review May 31, 2024 14:38
@hortongn hortongn self-assigned this May 31, 2024
@hortongn
Copy link
Member

hortongn commented Jun 3, 2024

@Janell-Huyck Has this PR been test deployed to libappstest or does it have the deploy bug you're working on?

@Janell-Huyck
Copy link
Contributor Author

It's been deployed successfully and does not have the same issue as the deploy but I'm working on.

@Janell-Huyck Janell-Huyck force-pushed the 509-set-node-version-in-deploys branch from 0efecad to 83432fd Compare June 6, 2024 12:59
@Janell-Huyck Janell-Huyck force-pushed the 509-set-node-version-in-deploys branch from 1753afd to 856df11 Compare June 6, 2024 13:25
@Janell-Huyck
Copy link
Contributor Author

Updated to allow Rails version to bump - went from ~>6.1.7.7 to ~>6.1.7. There was a Brakeman error for the older Rails version. After updating the Rails pinned version, I ran bundle update.

@hortongn hortongn merged commit 6fe384e into qa Jun 6, 2024
2 checks passed
@hortongn hortongn deleted the 509-set-node-version-in-deploys branch June 6, 2024 13:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set node version when deploying to servers
2 participants