Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add tests for functions (prepare for sites.ucsc.edu) #21

Closed
knice opened this issue Mar 8, 2024 · 0 comments · Fixed by #24
Closed

Add tests for functions (prepare for sites.ucsc.edu) #21

knice opened this issue Mar 8, 2024 · 0 comments · Fixed by #24
Assignees
@Herm71
Labels
change Change to an existing but not broken feature

Comments

@knice
Copy link
Member

knice commented Mar 8, 2024

Anytime we use a WordPress core API function, we need to use a conditional to check that the function exists. That gives us backwards compatibility and ensures we don't cause any unplanned PHP errors on sites with older themes and plugins.
@knice knice added the change Change to an existing but not broken feature label Mar 8, 2024
Herm71 added a commit that referenced this issue May 28, 2024
@Herm71
Add tests for functions (prepare for sites.ucsc.edu)
d448fad 
#21
This was referenced May 28, 2024
Merged
Open
Herm71 added a commit that referenced this issue May 29, 2024
@Herm71
Fix merge conflict from previous PR. #21
838b3eb
Herm71 added a commit that referenced this issue May 31, 2024
@Herm71
refactor admin-menus to fix merge conflict #21
5094b2b
knice pushed a commit that referenced this issue Jun 7, 2024
@Herm71
feat: ensure the plugin properly checks for functions before calling …
ba4f8b4 
…them

Fixes #21
@knice knice closed this as completed in #24 Jun 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Herm71 Herm71

Labels
change Change to an existing but not broken feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: ⚙️ make plugin fully "pluggable" ucsc/ucsc-custom-functionality
2 participants
@knice @Herm71