Run destructors when clearing PinVec #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a Drop impl for PinVec, and removes the Drop impl for PinSlab since PinSlab's Drop is redundant now. Fixes udoprog#20
This was referenced Apr 25, 2022
udoprog
approved these changes
Apr 26, 2022
|
You can merge as-is or you can apply the suggestion. Your choice! |
|
Thanks for adding me to the repo! I'll go ahead and merge this with the change you mentioned. Please take a look though and I'm happy to make additional changes if needed. |
udoprog
reviewed
Apr 26, 2022
| // will not be accessed again. | ||
| unsafe { drop_in_place(self.get_mut(i).unwrap()) } | ||
| if mem::needs_drop::<T>() { | ||
| let (last_slot, offset, _) = calculate_key(self.len()); |
udoprog
reviewed
Apr 26, 2022
| // Safety: we initialized slice to only point to the already-initialized elements. | ||
| // It's safe to drop_in_place because we are draining the Vec. | ||
| unsafe { | ||
| let slice: &mut [T] = mem::transmute(slice); |
There was a problem hiding this comment.
I think I'm partial to casting to a pointer above and reconstituting it as a slice over transmuting a slice. But both are equally correct to me so I don't mind it.
Here's that version:
let len = if i < last_slot { slot.len() } else { offset };
drop_in_place(from_raw_parts_mut(slot.as_mut_ptr() as *mut T, len));
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a
Dropimpl forPinVec, and removes theDropimpl forPinSlabsincePinSlab'sDropis redundant now.Fixes #20, and also includes the test from #19.