fix orderedList truncated after the codeBlock is deleted in the order… #4388
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdbch
reviewed
Aug 28, 2023
| @@ -138,6 +138,12 @@ export const CodeBlock = Node.create<CodeBlockOptions>({ | |||
| } | |||
|
|
|||
| if (isAtStart || !$anchor.parent.textContent.length) { | |||
| if (this.editor.isActive('orderedList')) | |||
There was a problem hiding this comment.
I think using defined extensions here to solve this is the wrong way because this issue will appear in other types of nodes too I guess.
There was a problem hiding this comment.
Oh, you are right. It's because I haven't thought about it comprehensively enough.
I'm currently modifying it like this in the project.
There was a problem hiding this comment.
I'll think about this for some time. The solution should work for all kind of wrapping nodes if possible.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
fix orderedList truncated after the codeBlock is deleted in the orderedList.
How did you accomplish your changes
Currently using clearNodes to delete the code block when the code block is empty. However, when the code block is in an ordered list, deleting this code block causes the ordered list to be truncated.
In order to solve this problem, we can additionally process the ordered list in the delete event, instead of deleting the code block through clearNodes, delete it through deleteNode.
How have you tested your changes
Yes. As the code change is very small, I verified it by applying the same change to my local node_modules folder.
How can we verify your changes
To reproduce the problem, just insert a block code in the ordered list, then type a Backspace and you should see the exception, the ordered list is truncated.
After applying this change, the issue was fixed.
Remarks
[add any additional remarks here]
Checklist
Related issues
[add a link to the related issues here]