Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add option to set rel on youtube embed link #6083

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

teamclouday
Copy link

Changes Overview

Add sameChannelRel option to youtube extension, according to the embed url parameter description.

Implementation Approach

Following the same pattern as other parameters.

Testing Done

Not sure how to write a test for this.

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: dfc7e5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/extension-youtube Patch
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit dfc7e5c
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/67a68faf16db820008a407d0
😎 Deploy Preview https://deploy-preview-6083--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@teamclouday
Copy link
Author

Btw I also think this code is wrong, because it skips the rest of url parameters configurations if the copied link has youtu.be, which is true in current youtube website when click on the share button

return `${getYoutubeEmbedUrl(nocookie)}${id}`

@teamclouday
Copy link
Author

teamclouday commented Feb 4, 2025

Also probably better to first parse the url using new URL(url), and then merge the new search params based on the configuration, with the existing ones, to avoid having multiple ? in the link.

I can create new PRs if necessary

Copy link
Contributor

@alexvcasillas alexvcasillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just left a minor nit in terms of following more closely the YouTube documentation for the embedded player parameters. Otherwise, looks great 👍🏻

We would also need a changeset for this addition :)

packages/extension-youtube/src/utils.ts Outdated Show resolved Hide resolved
@alexvcasillas
Copy link
Contributor

Also probably better to first parse the url using new URL(url), and then merge the new search params based on the configuration, with the existing ones, to avoid having multiple ? in the link.

I can create new PRs if necessary

Feel free to contribute with as what you think it would significantly improve the overall experience of the user for this particular extension :)

@teamclouday
Copy link
Author

Feel free to contribute with as what you think it would significantly improve the overall experience of the user for this particular extension :)

Sounds good! I'll create another PR after this one is merged!

Copy link
Contributor

@alexvcasillas alexvcasillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks for addressing the changes 🙇🏻

Copy link
Contributor

@alexvcasillas alexvcasillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that you applied a major change instead of a patch change, please, switch it to patch instead, we don't want a major bump in all of the packages for a patch :)

.changeset/thirty-forks-share.md Outdated Show resolved Hide resolved
Copy link
Member

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants