Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correct inconsistence #58

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Correct inconsistence #58

merged 2 commits into from
Nov 1, 2017

Conversation

cmplstofB
Copy link
Contributor

I corrected some inconsistent regulations for translation English to Japanese words.

  • Spaces between Japanese words and English ones (e.g. 「SKK 入力方式」)
  • Macrons at the end of the Katakana words (e.g. 「サーバ」)

I corrected some inconsistent regulations for translation English to Japanese words.
* Spaces between Japanese words and English ones (e.g. 「SKK 入力方式」)
* Macrons at the end of the Katakana words (e.g. 「サーバ」)
po/ja.po Outdated
@@ -85,11 +85,11 @@ msgstr "システム"

#: ../src/ibus-skk-preferences.ui.in.h:5
msgid "User"
msgstr "ユーザー"
msgstr "ユーザ"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which guidelines are you referring to? I heard that the recent JIS standard (Z8301) rather suggests to keep the macron at the end if the original English word ends with -er, -or, or -ar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it just because that; in 72th line in po/ja.po, it sees "ユーザ," but in 88th line in it, it sees "ユーザー", not "ユーザ."

The two words are inconsistent. If you think "ユーザー" is right, please fix "ユーザ" in 72th line.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Yes, I prefer the form with a macron. Would you mind updating the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course.
Now I update po/ja.po.


I am grateful to you for your awesome program, IBus-SKK, thanks!

@ueno ueno merged commit 83a930a into ueno:master Nov 1, 2017
@cmplstofB cmplstofB deleted the patch-1 branch November 1, 2017 07:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants