Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Extension fills dev console with console.warn #351

Closed
2 tasks done
victorz opened this issue Feb 12, 2024 · 2 comments · Fixed by #354 or #350
Closed
2 tasks done

Extension fills dev console with console.warn #351

victorz opened this issue Feb 12, 2024 · 2 comments · Fixed by #354 or #350
Labels
bug Something isn't working

Comments

@victorz
Copy link

victorz commented Feb 12, 2024

The issue is already reported or known issue?

  • I have searched the existing issues on github
  • I am using the latest version

Current behavior

This extension spews the following message:

unexpected message format: SyntaxError: JSON.parse: unexpected character at line 1 column 2 of the JSON data
    listen WindowMessageListener.ts:46

in the dev console, over and over, at least once per second if not more. The offending line.

Definitely should not leave a console.warn in production. It's flooding my console when I'm trying to do web development, making my job harder during the day. I have to disable the extension for my development.

I don't know whether or not the message itself indicates something seriously wrong, but it's definitely not wanted. I hope the issue can be resolved by either removing the console.warn from this extension, or fixing the issue itself, of trying to parse something as JSON which is not JSON.

Expected behavior

Don't spew warnings in the user's dev console.

Steps to reproduce

  1. Open any page.
  2. Open the dev console.
  3. The extension starts to spew warnings in there.

Environment

  • OS: Arch Linux
  • Browser: Firefox 122.0.1
  • Vimmatic version: 0.6.1
@victorz victorz added the bug Something isn't working label Feb 12, 2024
@hyshka
Copy link

hyshka commented Feb 15, 2024

I have the same issue with a similar setup. Let me know if there's any info I can contribute.

@ueokande ueokande mentioned this issue Feb 16, 2024
Merged
ueokande added a commit that referenced this issue Feb 17, 2024
@ueokande
fix: ignore unexpected message (#354)
ac302cd 
Ignore unexpected message from `window.postMessage()` on the content
script. The content script can receive messages from other than the
add-on, the loaded page or other addons.

close #351
@github-actions github-actions bot mentioned this issue Feb 17, 2024
Merged
@glutaminefree
Copy link

Hi! Please push this release to Firefox/Chrome extensions stores. Latest version on both is 0.6.1.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore unexpected message ueokande/vimmatic
chore(master): release 0.7.0 ueokande/vimmatic
3 participants
@victorz @hyshka @glutaminefree