-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cannot load JSON file on top of sample data #347
Comments
How about we ask the user if they would like to replace the existing map or merge into it? So, the dialog should contain three choices / buttons: Replace, Merge, Cancel. When merging we should skip existing ones. |
I think replacing the whole graph is unnecessary. The user can clear all data and then load JSON file. Here we could always merge and ask user about already existing elements. Whether we should override the existing elements or skip them. |
I think it'd be good for convenience though. Almost all tools support this. Besides, I am not sure Data menu should be in the release. |
I think these buttons could be shown "Replace, Merge, Cancel" but how we are going to merge is not clear. |
Let's implement a checkbox "Replace existing map on merge" (true by default). If unchecked, we should merge what's in the file with what's in the canvas. When an existing element is also in the file, we should overwrite it. |
…overriding in some cases)
I think merging graphs with JSON (overriding existing elements or skipping) could be easy. Inside expand-collapse extension, I tried to skip or override node or edge when it is added to cytoscape.js with function cy.add. It worked for basic graphs but when there are collapsed nodes or edges, I see some errors. I couldn't solve them. So instead of merging here we only provided to replace the existing graph. |
visuall.json.txt
We get "Cannot process provided JSON file!". If we load it before loading Sample data it loads fine!
The text was updated successfully, but these errors were encountered: