You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
We have an environment where the behavior of WDI5 is flaky : it works or it does not work from time to time.
After qualifying, we found that error in the traces :
Our qualification revealed that the injectTools script sometimes define window.compareVersions but sometimes it fails.
It comes from the fact that :
This injectTools script seems to use some kind of Universal Module Loader (testing define, exports...)
Depending on which libraries are being loaded in the UI5 environment (in particular when the FLP loads tons of tiles where some use 3rd party code), the define, exports or other magic keywords can be introduced to enable a compatibility layer with UI5
But in the end, the injectTools intends to add compareVersions to the window object only
Which means we should simplify the injectTools script to only add the function to the window object.
To Reproduce
Too complex to explain here, I hope the description above is clear enough.
It really depends on the FLP configuration and environment.
Expected behavior
The injectTools being used by WDI5 to instrument the browser environment with expected tools should only consider the browser environment (and not any possible environment).
Logs/Console Output
N/A
Screenshots
See problem description
Runtime Env (please complete the following information):
wdi5/wdio-ui5-service-version: latest
UI5 version: 1.110.x
wdio-version (output of wdio --version): not relevant
node-version (output of node --version): not relevant
OS: not relevant
Chrome + latest (but shall be true for all browsers)
Additional context @nair-sumesh spent 2 days qualifying the issue before contacting me and we nailed it together !
The text was updated successfully, but these errors were encountered:
Describe the bug
We have an environment where the behavior of WDI5 is flaky : it works or it does not work from time to time.
After qualifying, we found that error in the traces :
Our qualification revealed that the
injectTools
script sometimes definewindow.compareVersions
but sometimes it fails.It comes from the fact that :
define
,exports
...)define
,exports
or other magic keywords can be introduced to enable a compatibility layer with UI5compareVersions
to thewindow
object onlyWhich means we should simplify the
injectTools
script to only add the function to thewindow
object.To Reproduce
Too complex to explain here, I hope the description above is clear enough.
It really depends on the FLP configuration and environment.
Expected behavior
The
injectTools
being used by WDI5 to instrument the browser environment with expected tools should only consider the browser environment (and not any possible environment).Logs/Console Output
N/A
Screenshots
See problem description
Runtime Env (please complete the following information):
wdi5/wdio-ui5-service
-version: latestUI5
version: 1.110.xwdio
-version (output ofwdio --version
): not relevantnode
-version (output ofnode --version
): not relevantAdditional context
@nair-sumesh spent 2 days qualifying the issue before contacting me and we nailed it together !
The text was updated successfully, but these errors were encountered: