Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature/control info #214

Merged
merged 16 commits into from
Apr 20, 2022
Merged

Feature/control info #214

merged 16 commits into from
Apr 20, 2022

Conversation

dominikfeininger
Copy link
Collaborator

add more metadata information to wdi5 control for easier verification of represented ui5 control

@dominikfeininger dominikfeininger requested a review from vobu April 8, 2022 13:55
@dominikfeininger dominikfeininger marked this pull request as draft April 8, 2022 13:55
@dominikfeininger dominikfeininger changed the title WIP: Feature/control info Feature/control info Apr 8, 2022
@dominikfeininger dominikfeininger self-assigned this Apr 8, 2022
@vobu vobu mentioned this pull request Apr 12, 2022
Closed
@dominikfeininger dominikfeininger marked this pull request as ready for review April 12, 2022 12:04
vobu
vobu reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good code-wise - please add some documentation on how to use the API in

  • docs/usage.md → explanation and example
  • docs/recipe.md → short, concise usage example

This was linked to issues Apr 20, 2022
Add control information properties to wdi5-control #182
Closed
Add control information properties to wdi5-control #208
Closed
@dominikfeininger
Copy link
Collaborator Author

all good code-wise - please add some documentation on how to use the API in

  • docs/usage.md → explanation and example
  • docs/recipe.md → short, concise usage example

missed that comment. Will be done today.

@vobu vobu merged commit 073d917 into main Apr 20, 2022
@vobu vobu deleted the feature/controlInfo branch April 20, 2022 19:13
vobu pushed a commit that referenced this pull request Apr 20, 2022
@dominikfeininger @vobu
feat(wdi5-control): .getControlInfo() for info on capabilities (#214)
965d8bb 
* feat(metadata): wip for wdi5 clas members

* feat(metadata): wip for wdi5 clas members

* feat(metadata): wip for wdi5 class members

* fix: use getAllPublicMethods ui5 api

* fix: rm use of getPublicMethods due to deprecation

* feat(controlinfo): add control info methods and test

* docs: add generated method doc examples

* chore: rm unnecessary imports

* feat(controlinfo): add control info methods and test

* fix: wdio bridge

* docs: add usage and recipe

Co-authored-by: dominik.feininger <dominik.feininger@js-soft.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vobu vobu vobu approved these changes

Assignees

@dominikfeininger dominikfeininger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add control information properties to wdi5-control Add control information properties to wdi5-control
2 participants
@dominikfeininger @vobu