Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: sap build workzone std ed enablement #520

Merged
merged 17 commits into from
Aug 29, 2023

Conversation

vobu
Copy link
Contributor

@vobu vobu commented Aug 28, 2023

→ original PR was #447, this is the update for wdi5 2.0

[x] set browser scope to iframe in wz std ed for operation
[x] support disabling biometric auth on BTP when IAS is used as IdP
[x] unify timeout (waitForUI5) btw Node.js- and browser(UI5)-scope
[ ] expose WorkzoneShell as FE test library facade for enabling back navigation (@Siolto)
→ postponed
[x] >= 1 test for each of the above
[x] add docs & recipes

thanks heaps to @jasper07 and @gregorwolf for all the research and triage work!!!

closes #378

@vobu vobu temporarily deployed to internal August 28, 2023 10:01 — with GitHub Actions Inactive
@vobu vobu temporarily deployed to internal August 28, 2023 15:51 — with GitHub Actions Inactive
@vobu vobu temporarily deployed to internal August 29, 2023 09:09 — with GitHub Actions Inactive
@vobu vobu temporarily deployed to internal August 29, 2023 09:48 — with GitHub Actions Inactive
so we make the necessary secrets available external PRs also
@vobu vobu temporarily deployed to internal August 29, 2023 10:00 — with GitHub Actions Inactive
@vobu vobu temporarily deployed to internal August 29, 2023 12:10 — with GitHub Actions Inactive
@vobu vobu temporarily deployed to internal August 29, 2023 12:20 — with GitHub Actions Inactive
@vobu vobu temporarily deployed to internal August 29, 2023 13:22 — with GitHub Actions Inactive
@vobu vobu temporarily deployed to internal August 29, 2023 13:37 — with GitHub Actions Inactive
Copy link
Collaborator

@Siolto Siolto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vobu vobu temporarily deployed to internal August 29, 2023 14:14 — with GitHub Actions Inactive
@vobu vobu merged commit 8f6c217 into main Aug 29, 2023
@vobu vobu deleted the feat/sap-build-wz-std-ed-enablement branch August 29, 2023 14:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test times out when running on BTP Launchpad
2 participants