Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove uses of regex library #25

Open
indiv0 opened this issue May 20, 2017 · 2 comments
Open

Remove uses of regex library #25

indiv0 opened this issue May 20, 2017 · 2 comments

Comments

@indiv0
Copy link
Collaborator

indiv0 commented May 20, 2017

This line will contain our last regex usage once #24 lands. We should compare the performance to a nom-based parser (if it fits in this use-case), and remove the regex lib if necessary.

This would let us remove the regex library as a dependency entirely.

@uiri
Copy link
Owner

uiri commented May 20, 2017

You missed a spot in src/util.rs.

The one you missed is fairly easy to replace with String::starts_with

The one you highlight in the session submodule of the user module is rather difficult to replace with string operations. It contains optional path separators between the components that it is looking for so it would need to be replaced with 4 strings (without either separators, with the first, with the second, with both separator).

Closing as WONTFIX; re-open if you have any objections to or see any flaws in my reasoning.

@uiri uiri closed this as completed May 20, 2017
@indiv0
Copy link
Collaborator Author

indiv0 commented May 20, 2017

With string-based operations it might be difficult, but I think it's still doable with nom. I'd still like to at least give it a try.

@indiv0 indiv0 reopened this May 20, 2017
indiv0 added a commit that referenced this issue May 20, 2017
Address problems brought up in #25
@indiv0 indiv0 assigned indiv0 and unassigned indiv0 May 22, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants