Code updated to follow Google Python Style Guide #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes variable names and restructures part of the code to follow Google Python Style Guide (https://google.github.io/styleguide/pyguide.html#s3.16.2-naming-conventions). Pylint is used to measure the code quality, however not all suggestions are adapted as I believe they are not very reasonable in this context.
the previous commit didn't pass hte type checker on github workflow, on my machine however it does. I reversed the previous restructuring.
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 92.88% 95.47% +2.58%
==========================================
Files 6 6
Lines 225 221 -4
Branches 35 33 -2
==========================================
+ Hits 209 211 +2
+ Misses 13 9 -4
+ Partials 3 1 -2
Continue to review full report at Codecov.
|
In hte current implementation the parameters "labels" and "label_border" are moved from make_realization() to Model(). I forgot to update the Readme.md in the previous commit
Sosnowsky
approved these changes
Jan 28, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes variable names and restructures parts of the code to follow the Google Python Style Guide (https://google.github.io/styleguide/pyguide.html#s3.16.2-naming-conventions). Pylint is used to measure the code quality, however not all suggestions are adapted as I believe they are not very reasonable for this project.