Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

beforeClosed callback added #111

Merged
merged 2 commits into from
Nov 20, 2017
Merged

beforeClosed callback added #111

merged 2 commits into from
Nov 20, 2017

Conversation

dimailn
Copy link
Contributor

@dimailn dimailn commented Nov 17, 2017

Fixes #

Changes proposed in this pull request:

Added the callback for intercept the event of closing modal.

@wxsms

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 98.192% when pulling 814b6e5 on dimailn:before-close into 605176e on wxsms:master.

wxsms
wxsms requested changes Nov 17, 2017
View reviewed changes
Copy link
Member

@wxsms wxsms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enhance this PR with:

  • use isFunction(this.beforeClose) instead of raw this.beforeClose
  • Add your new prop to document
  • Fill tests to cover your new code

wxsms
wxsms approved these changes Nov 20, 2017
View reviewed changes
Copy link
Member

@wxsms wxsms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind. let me do these.

@wxsms wxsms merged commit 5d978a1 into uiv-lib:master Nov 20, 2017
wxsms added a commit that referenced this pull request Nov 20, 2017
@wxsms
#111 enhance doc & test
a79bb7b
@dimailn
Copy link
Contributor Author

dimailn commented Nov 20, 2017

Thank you =) I stalled with tests.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wxsms wxsms wxsms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimailn @coveralls @wxsms