Fixes #191 - Fire before-change event in tabs components #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxsms
requested changes
Mar 22, 2018
There was a problem hiding this comment.
Thanks for the effort! pls:
- remove
Promiseusage because it is not supported by IE at all. - use
onBeforeChange(index, done)， whereindexis the index to change, anddoneis the callback function, callingdone()without param will allow the change, anddone(err)(err can be anything) will deny it. - no need for the timeout checking because it can totally control by user.
- remove Promises - send 2 parameters (index, done function) to `before-change` event handler - remove timeout - code refactoring: emitting `input` event when `before-change` handler prevents tab display; remove currentIndex watcher
|
Requested changes resolved |
wxsms
approved these changes
Mar 23, 2018
|
Thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fire before-change event in tabs components. If event handler return false - not show clicked tab
Is this a bug fix or enhancement?
Enhancement
Is there a related issue?
Fixes #191
Any Breaking changes?
No