Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[DatePicker] translating by locale prop #221

Merged
merged 2 commits into from
Jun 21, 2018
Merged

[DatePicker] translating by locale prop #221

merged 2 commits into from
Jun 21, 2018

Conversation

SzNagyMisu
Copy link
Contributor

Is this a bug fix or enhancement?

Enhancement

Is there a related issue?

#219

Any Breaking changes?

Possibility to pass locale in DatePicker props with locale object for custom translations.

wxsms
wxsms approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@wxsms wxsms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.196% when pulling 44d2783 on SzNagyMisu:m_pr into b82a236 on wxsms:master.

@wxsms wxsms merged commit 78e0a7c into uiv-lib:master Jun 21, 2018
wxsms added a commit that referenced this pull request Jun 21, 2018
@wxsms
Revert "[DatePicker] translating by locale prop (#221)"
9aa5ec2 
This reverts commit 78e0a7c.
@SzNagyMisu SzNagyMisu deleted the m_pr branch August 6, 2018 08:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wxsms wxsms wxsms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SzNagyMisu @coveralls @wxsms