Enhancement: setting delay to show/hide popover

[feliupe]

Is this a bug fix or enhancement?

Enhancement.

Is there a related issue?

I want to make possible to set an delay to show/hide a popover. Just like the Bootstrap Tooltip.

It can be very annoying being unable to set in cases like tables, where you have all the cells around also wrapped in a popover. If you hover really fast from on side to the other of the table you will be unable to see some cells as the popover is shown the moment you hover one on it side.

Let me know if you don't get it. I can add screenshots later.

Any Breaking changes?

Yes. Thought, I can work around it, by not removing transitionDuration for now.

---

Please let me know if it sounds like something for you, so that I can work on it better - with your help - and also write tests.

We use all over the client where I work, and we would be pretty much interested in having it merged.

[coveralls]

Coverage decreased (-0.1%) to 97.328% when pulling 7578092 on feliupe:master into a95fdb2 on wxsms:master.

[wxsms]

Hi, thank you for using this lib. the idea sounds good, but:

1. transitionDuration has nothing to do with delays, this props is to indicate how fast the hiding / showing transition is, therefore this should not be a breaking change, and should not have any affect to this prop. you should use a new prop, something like delay, which contents {show: Number, hide: Number}
2. pls fix lint errors after making changes
3. it's better to have unit tests for this feature

[wxsms]

pls see my comment

[feliupe]

Hi @wxsms , thanks for your reply.

1. I am sorry, but maybe I am missing or misunderstanding something.

this props is to indicate how fast the hiding / showing transition is[...]

I can't see any use of transitionDuration for showing anything related to popUpMixin.js - and the only two components that are apparently using it are the Tooltip and the Popover.

There is only one reference, when hiding the popup:

https://github.com/wxsms/uiv/blob/a95fdb2f9c5d7fc925dabc8d85a5915fd3a86ae2/src/mixins/popupMixin.js#L214-L225

One more thing that I've noticed is that it is not quite a duration for hidding it.

Inside the setTimeout callback it's only being removed from the DOM. The hide itself, as I see, happens outside, and before with removeClass(this.$refs.popup, SHOW_CLASS). As I see, this serves solely to wait a bit before the css fade transition of hiding it happens. If you set it to 20000 it will be hidden in less than one second anyways.

As a sidenote I would be also happy in documenting (writing an example) better this transition-duration, if you could help with it by explaining the desired result to me.

2. done
3. done

Thanks :)

[wxsms]

pls see my comment in code.

[wxsms]

There might be a bug: while you clearing hideTimeoutId, if the inner code have already run, the inner timeout will not be cleared. and it will still be removed from DOM while time arrived.

[feliupe]

hi @wxsms , you are right. Please check out my last commit 7578092

Thanks :)

[wxsms]

@feliupe done. will release on next version. thanks.