Skip to content

fix:react 17 报错问题 (#216) #217

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 23, 2022
Merged

fix:react 17 报错问题 (#216) #217

merged 13 commits into from
Apr 23, 2022

Conversation

SunLxy
Copy link
Contributor

@SunLxy SunLxy commented Apr 23, 2022 •
edited
Loading

  1. react-dom 小于 v18版，命令行会有Module not found:Error: Can't resolve 'react-dom/client' 这个报错，可以忽略

@vercel
Copy link

vercel bot commented Apr 23, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/398188662/react-code-preview/AhzoDJ5YdAcLkEek79DaKqL47a3p
✅ Preview: https://react-code-preview-git-fork-sunlxy-master-398188662.vercel.app

jaywcjlove
jaywcjlove reviewed Apr 23, 2022
View reviewed changes
package.json Outdated
"@uiw/react-github-corners": "~1.5.14",
"@uiw/react-markdown-preview": "~4.0.6",
"@uiw/react-github-corners": "~1.5.3",
"@uiw/react-markdown-preview": "~3.5.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SunLxy 在 "@uiw/react-markdown-preview": "~4.0.6" 报错？

jaywcjlove
jaywcjlove reviewed Apr 23, 2022
View reviewed changes
src/useCodePreview.ts
// 判断是否是 react v18版本
const isV18 = Reflect.has(V18ReactDOM || {}, 'createRoot');
const isV18 = Reflect.has(V18ReactDOM, 'createRoot');
const NewReactDOM = isV18 ? ReactDOMRender(V18ReactDOM) : V18ReactDOM;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SunLxy 处理方法仍然有问题，我们的代码放到 codepen 和 codesandbox 中是可以预览的

image

@jaywcjlove
Copy link
Member

@SunLxy 文档中的示例处理一下。

@jaywcjlove jaywcjlove merged commit e98476c into uiwjs:master Apr 23, 2022
github-actions bot added a commit that referenced this pull request Apr 23, 2022
@github-actions
v5.1.1 fix: 修复 react 17 中报错问题 (#216) (#217) e98476c
4a331fb
@jaywcjlove
Copy link
Member

jaywcjlove commented Apr 23, 2022 •
edited
Loading

https://codesandbox.io/s/uiw-react-code-preview-react-18-1bmhhd?from-embed=&file=/src/App.js

在 React 18 下面报警告。 @SunLxy

Warning: ReactDOM.render is no longer supported in React 18.
Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17.
 Learn more: https://reactjs.org/link/switch-to-createroot

@SunLxy
Copy link
Contributor Author

SunLxy commented Apr 23, 2022

这块要改掉 https://codesandbox.io/s/uiw-react-code-preview-react-18-forked-kqhhgp?file=/src/index.js
image
@jaywcjlove

@SunLxy
Copy link
Contributor Author

SunLxy commented Apr 23, 2022

umd 中报警告的等着修复吧 facebook/react#24274

@jaywcjlove
Copy link
Member

@SunLxy 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jaywcjlove jaywcjlove jaywcjlove left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunLxy @jaywcjlove