Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update deps, fix config warnings #7

Closed
wants to merge 2 commits into from

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Dec 6, 2022

No description provided.

@ayrat555
Copy link
Contributor Author

ayrat555 commented Dec 6, 2022

@ulissesalmeida hello! can you please take a look?

@ulissesalmeida
Copy link
Owner

@ayrat555

Sure! Thank you for your contribution.

I can see there are 4 major changes here:

  1. Supporting Elixir latest version
  2. Deprecate older Elixir version by using import Config
  3. Dependabot addition
  4. GitHub Actions migration

Would you mind splitting these changes on different PRs?

I think it's alright to do 1 + 2 in a single PR.

The 3. and 4. I would like to address them on different PRs.

The 4), GitHub Actions migration:
Isn't clear to me why we should stop using CircleCI, is there anything on CircleCi that is impossible to do without GitHub actions? I had a local branch that I was planning to migrate to Earthly and use a Earthfile like in ecto. Example:
https://github.com/elixir-ecto/ecto/blob/master/Earthfile
I never finish that, but one day I'll do. That's why I'm not totally inclined to do pure Github Actions.

Thank you again for coming and suggesting these changes.

@ayrat555
Copy link
Contributor Author

ayrat555 commented Dec 7, 2022

@ulissesalmeida I separated this pr into:

for now I didn't create a github actions config. personally I think it's easier to use because doesn't use external integrations.

@ayrat555 ayrat555 closed this Dec 7, 2022
@ulissesalmeida
Copy link
Owner

@ayrat555 The v1.2.0 is out, thank you 🎉

@ulissesalmeida
Copy link
Owner

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants