Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Action only returns 30 entries. Can you add pagination support? #3

Closed
wushujames opened this issue Feb 19, 2020 · 2 comments
Closed

Comments

@wushujames
Copy link
Contributor

Hi,

I'm using your action. It appears to only return 30 entries. Apparently that is the number of files returned in a single "page" of the GET /repos/:owner/:repo/pulls/:pull_number/files API you are using. https://developer.github.com/v3/pulls/#list-pull-requests-files

Is it possible to add pagination support, to get the full list of files? I tried doing it myself, but I don't really know node.js. And I tried downloading your repo and tried to figure out how to build it, but I couldn't figure it out. I got compilation errors.

Thanks!

duarten added a commit that referenced this issue Feb 19, 2020
Instead of just the first one.

Refs #3

Signed-off-by: Duarte Nunes <duarte.m.nunes@gmail.com>
duarten added a commit that referenced this issue Feb 19, 2020
Instead of just the first one.

Refs #3

Signed-off-by: Duarte Nunes <duarte.m.nunes@gmail.com>
@duarten
Copy link
Member

duarten commented Feb 19, 2020

Hi,

Thanks for the issue! I added pagination supported and released v3.0.1 with the fix. Could you please check if it solves your issue?

@wushujames
Copy link
Contributor Author

It worked! I tested changed-files on a pull request. Previously, I could only see 30 files. With v3.0.1, I can see 38 files. So, it seems like it's working!

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants