Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add optional pattern to filter file types. #4

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

robdodson
Copy link
Contributor

I really like this action, but I've found that I often want to filter the outputs that it produces and hand them to other tasks such as linters. This PR adds an optional pattern input which is a regex that defaults to .* that can be used to filter the files that end up in each array.

I haven't been able to build and test the changes so, if you like the PR, you might need to try it against a test project.

Copy link
Member

@duarten duarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! :D Looks good in general, I just have a small comment.

src/main.ts Show resolved Hide resolved
@robdodson
Copy link
Contributor Author

@duarten I added a conditional to check the renamed file. What do you think?

@duarten
Copy link
Member

duarten commented Mar 25, 2020

@robdodson Looks great, thanks!

@duarten duarten merged commit 9a5cb1c into umani:master Mar 25, 2020
duarten pushed a commit that referenced this pull request Mar 25, 2020
I really like this action, but I've found that I often want to filter the outputs that it produces and hand them to other tasks such as linters. This PR adds an optional pattern input which is a regex that defaults to .* that can be used to filter the files that end up in each array.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants