-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
V15: Allows certain adjustments of the logo #18499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekelleher
reviewed
Mar 3, 2025
leekelleher
approved these changes
Mar 3, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/Umbraco.Web.UI.Client
andsrc/Umbraco.Web.UI.Login
directories, focusing on theapp-logo.element.ts
,backoffice-header-logo.element.ts
, andauth-layout.element.ts
files. The changes enhance the flexibility and customization of logo elements and improve code consistency.This should resolve #18424
Changes
Enhancements to Logo Elements:
This pull request introduces support for an alternative backoffice logo, along with various updates to the logo handling in the application. The changes span across multiple files, including controllers, configurations, UI components, and mock handlers.
Addition of Alternative Backoffice Logo:
src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeGraphicsController.cs
: Added a new routeLogoAlternativeRouteName
and a corresponding methodLogoAlternative
to handle requests for the alternative backoffice logo. [1] [2]src/Umbraco.Core/Configuration/Models/ContentSettings.cs
: Introduced a new propertyBackOfficeLogoAlternative
to store the path to the alternative backoffice logo. [1] [2]Updates to UI Components:
src/Umbraco.Web.UI.Client/src/apps/app/app-logo.element.ts
: Enhanced theUmbAppLogoElement
component to support loading attributes, logo types, and theme overrides. Updated the rendering logic to select the appropriate logo based on the theme and logo type. [1] [2]src/Umbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-header-logo.element.ts
: Modified theUmbBackofficeHeaderLogoElement
to use the updatedUmbAppLogoElement
with the new properties and removed redundant context consumption. [1] [2] [3] [4] [5]src/Umbraco.Web.UI.Login/src/components/layouts/auth-layout.element.ts
: Added CSS properties for customizing the logo display and updated the rendering logic for the logo images. [1] [2] [3] [4] [5]