Prevents attempt to move an item to itself as a parent #18550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves: #18544
Description
The linked issue notes that it's possible to select the current item as the parent for a move, which isn't valid.
Ideally this would be solved via the
pickableFilterI would imagine, but I had trouble getting that to work. So instead have just checked for this condition after selection and presented a friendlier error message.It would be better to not allow selection in the first place, so if you can find a way to do that, please do, and close this! But if it's actually tricky, this would probably be an improvement on what we have currently.