-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds CONST for 'Umb.Condition.WorkspaceAlias' #2454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@iOvergaard from the discussion/issue Would be good to get your eyes on this please |
…braco-cms/backoffice/workspace' as the import
bjarnef
reviewed
Oct 14, 2024
iOvergaard
reviewed
Oct 14, 2024
src/packages/core/workspace/conditions/workspace-alias.condition.ts
Outdated
Show resolved
Hide resolved
…on.ts Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
@iOvergaard & @bjarnef |
iOvergaard
approved these changes
Oct 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UMB_WORKSPACE_CONDITION_ALIAS
to replace the string usage of'Umb.Condition.WorkspaceAlias'
UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS
and marksUMB_WORKSPACE_ENTITY_IS_NEW_CONDITION
as deprecatedUMB_WORKSPACE_HAS_COLLECTION_CONDITION_ALIAS
and marksUMB_WORKSPACE_HAS_COLLECTION_CONDITION
as deprecatedTypes of changes
Motivation and context
To help developers using conditions not having to remember the exact string syntax of this common condition but instead can refer to this const instead.
How to test?
Screenshots (if appropriate)
Checklist