Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds CONST for 'Umb.Condition.WorkspaceAlias' #2454

Merged
merged 13 commits into from
Oct 15, 2024

Conversation

warrenbuckley
Copy link
Contributor

@warrenbuckley warrenbuckley commented Oct 14, 2024

Description

  • Adds a new const UMB_WORKSPACE_CONDITION_ALIAS to replace the string usage of 'Umb.Condition.WorkspaceAlias'
  • Adds UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS and marks UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION as deprecated
  • Adds UMB_WORKSPACE_HAS_COLLECTION_CONDITION_ALIAS and marks UMB_WORKSPACE_HAS_COLLECTION_CONDITION as deprecated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

To help developers using conditions not having to remember the exact string syntax of this common condition but instead can refer to this const instead.

How to test?

  • Ensure build is still OK and tests pass

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@warrenbuckley
Copy link
Contributor Author

@iOvergaard from the discussion/issue
umbraco/Umbraco-CMS#17270

Would be good to get your eyes on this please

…braco-cms/backoffice/workspace' as the import
@warrenbuckley
Copy link
Contributor Author

warrenbuckley commented Oct 14, 2024

@iOvergaard & @bjarnef
What do we think of this, now with your suggested changes?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants